[BUG]: Can't setParams to dispatcher beforeExecuteRoute

[crewsycrews]

Describe the bug

We want to setParams() of the dispatcher on beforeExecuteRoute event but it have no effect on the method.

Expected behavior

An ability to setParams() on beforeExecuteRoute event.

    /**
     * @param Event $event
     * @param Dispatcher $dispatcher
     * @throws ReflectionException
     */
    public function beforeExecuteRoute(Event $event, Dispatcher $dispatcher): void
    {
        $controllerName = $dispatcher->getControllerClass();
        $actionName = $dispatcher->getActiveMethod();
        try {
            $reflection = new ReflectionMethod($controllerName, $actionName);
        } catch (ReflectionException $e) {
            return;
        }

        $parameters = $this->instantiateParams($reflection, $dispatcher->getParams());
        // next line has no effect here
        $dispatcher->setParams($parameters);
    }

Details

• Phalcon version: 4.0.5
• PHP Version: 7.4.15
• Operating System: Linux
• Installation type: installing via package manager
• Zephir version (if any): Version 0.12.17-6724dbf
• Server: Nginx

[BeMySlaveDarlin]

beforeExecuteRoute expects first argument to be instance of Dispatcher, not Event

class ControllerBase extends Controller
{
    public function beforeExecuteRoute(Dispatcher $dispatcher): void
    {
        $dispatcher->setParams([1, 2, 3]);
    }
}

class IndexController extends ControllerBase
{
    public function indexAction()
    {
        var_dump($this->dispatcher->getParams());
        die();
    }
}

//array(3) { [0]=> int(1) [1]=> int(2) [2]=> int(3) }

[crewsycrews]

Sorry, I've not mentioned that beforeExecuteRoute declared in ServiceProvider, not in the controller. Can you check this one more time, please?

[kirill-voronov]

This happens because in line 335 of Dispatcher params are copied into local method variable

cphalcon/phalcon/Dispatcher/AbstractDispatcher.zep

Line 335 in 041a4e0

let params = this->params;

and since then only that variable is used, so any further call of $dispatcher->setParams has no effect, including such call in beforeExecuteRoute callback (in controller or plugin), because setParams modifies this->params not local params variable.

[kirill-voronov]

@BeMySlaveDarlin @Jeckerson @niden

[niden]

...
and since then only that variable is used, so any further call of $dispatcher->setParams has no effect, including such call in beforeExecuteRoute callback, because setParams modifies this->params not local params variable.

Reopening this - Thanks for pointing it out @kirill-voronov

[BeMySlaveDarlin]

@niden Looks like events firing during dispatch() method run doesn't affects params attribute because it was assigned to local variable as @kirill-voronov mentioned.
Made minor fix in #15794

[BeMySlaveDarlin]

Case using in controller or dispatcher itself fires before dispatch loop and works fine, but when using events managed way - it fires during dispatch loop and doesnt affects params

[niden]

Resolved in #15794

[kirill-voronov]

Thanks y'all ❤️

[niden]

@kirill-voronov Thank you for finding this. The second PR has tests that confirm that this works as expected.

#15795