Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T15603 before execute route #15795

Merged
merged 2 commits into from
Nov 18, 2021
Merged

T15603 before execute route #15795

merged 2 commits into from
Nov 18, 2021

Conversation

niden
Copy link
Member

@niden niden commented Nov 18, 2021

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Tests confirming the fix

Thanks

@niden niden requested a review from Jeckerson November 18, 2021 00:52
@niden niden self-assigned this Nov 18, 2021
@niden niden added 5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium labels Nov 18, 2021
@niden niden linked an issue Nov 18, 2021 that may be closed by this pull request
[BUG]: Can't setParams to dispatcher beforeExecuteRoute #15603
Closed
@niden niden mentioned this pull request Nov 18, 2021
Closed
@niden niden merged commit f617bc3 into phalcon:5.0.x Nov 18, 2021
@niden niden deleted the T15603-before-execute-route branch November 18, 2021 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium
Projects
Phalcon v5
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Can't setParams to dispatcher beforeExecuteRoute
2 participants
@niden @Jeckerson