Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T15603 Fix dispatcher setParams during dispatch loop #15794

Merged
merged 3 commits into from
Nov 17, 2021

Conversation

BeMySlaveDarlin
Copy link
Contributor

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:
Fixed Phalcon\Dispatcher\Dispatcher::setParams() not updating params during dispatch loop if using events case

Thanks

@BeMySlaveDarlin BeMySlaveDarlin self-assigned this Nov 17, 2021
@BeMySlaveDarlin BeMySlaveDarlin added 5.0 The issues we want to solve in the 5.0 release bug A bug report labels Nov 17, 2021
@BeMySlaveDarlin BeMySlaveDarlin linked an issue Nov 17, 2021 that may be closed by this pull request
@niden niden merged commit c89957b into phalcon:5.0.x Nov 17, 2021
@niden
Copy link
Sponsor Member

niden commented Nov 17, 2021

Thank you @BeMySlaveDarlin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Can't setParams to dispatcher beforeExecuteRoute
2 participants