T13007 nativearray missing patch

.travis.yml

@@ -13,6 +13,7 @@ branches:
   only:
     - master
     - /^(4|5)\.\d+\.(\d+|x)$/
+    - /^T\d+-[a-zA-Z-]+/
 
 addons:
   apt:

phalcon/translate/adapter/nativearray.zep

@@ -44,7 +44,7 @@ class NativeArray extends Adapter implements \ArrayAccess
 		}
 
 		if fetch error, options["triggerError"] {
-			let this->triggerError = true;
+			let this->triggerError = (bool) error;
 		}
 
 		if typeof data !== "array" {
@@ -68,7 +68,7 @@ class NativeArray extends Adapter implements \ArrayAccess
 	public function notFound(string! index) -> string
 	{
 		if (true === this->triggerError) {
-			trigger_error("Cannot find translation key: " . index, E_USER_NOTICE);
+			throw new Exception("Cannot find translation key: " . index);
 		}
 
 		return index;

tests/unit/Translate/Adapter/NativeArray/NotFoundCest.php

@@ -15,6 +15,7 @@
 use Phalcon\Test\Fixtures\Traits\TranslateTrait;
 use Phalcon\Test\Fixtures\Translate\Adapter\NativeAdapter;
 use Phalcon\Translate\Adapter\NativeArray;
+use Phalcon\Translate\Exception;
 use UnitTester;
 
 /**
@@ -55,7 +56,7 @@ public function translateAdapterNativearrayNotFoundTriggerError(UnitTester $I)
     {
         $I->wantToTest('Translate\Adapter\NativeArray - notFound() - triggerError');
         $I->expectThrowable(
-            new \Exception('Cannot find translation key: unknown', 1024),
+            new Exception('Cannot find translation key: unknown'),
             function () {
                 $language   = $this->getArrayConfig()['en'];
                 $translator = new NativeArray(
@@ -69,6 +70,32 @@ function () {
         );
     }
 
+    /**
+     * Tests Phalcon\Translate\Adapter\NativeArray :: notFound() - triggerError random value
+     *
+     * @param UnitTester $I
+     *
+     * @author Phalcon Team <team@phalconphp.com>
+     * @since  2018-11-13
+     */
+    public function translateAdapterNativearrayNotFoundTriggerErrorRandomVaue(UnitTester $I)
+    {
+        $I->wantToTest('Translate\Adapter\NativeArray - notFound() - triggerError random value');
+        $I->expectThrowable(
+            new Exception('Cannot find translation key: unknown'),
+            function () {
+                $language   = $this->getArrayConfig()['en'];
+                $translator = new NativeArray(
+                    [
+                        'content'      => $language,
+                        'triggerError' => 'blahblah',
+                    ]
+                );
+                $translator->query('unknown');
+            }
+        );
+    }
+
     /**
      * Tests Phalcon\Translate\Adapter\NativeArray :: notFound() - custom
      *