Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mvc\Micro cleanup and setModelBinder() fix #14171

Merged
merged 2 commits into from Jun 9, 2019

Conversation

@SidRoberts
Copy link
Member

commented Jun 8, 2019

Hello!

  • Type: bug fix | code quality
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • [-] I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • [-] I have created a PR for the documentation about this change

Also fixed a small bug whereby calling setModelBinder() without explicitly setting a DI first could cause problems.

@SidRoberts SidRoberts changed the title Micro handler array Mvc\Micro cleanup and setModelBinder() fix Jun 8, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 8, 2019

Codecov Report

Merging #14171 into 4.0.x will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.0.x   #14171      +/-   ##
==========================================
+ Coverage   74.56%   74.56%   +<.01%     
==========================================
  Files         455      455              
  Lines       94411    94429      +18     
==========================================
+ Hits        70394    70414      +20     
+ Misses      24017    24015       -2
Impacted Files Coverage Δ
ext/phalcon/mvc/micro.zep.c 81.42% <0%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b085af8...b47890d. Read the comment docs.

@Jurigag

Jurigag approved these changes Jun 8, 2019

@niden

niden approved these changes Jun 9, 2019

@niden niden merged commit 907bc0d into phalcon:4.0.x Jun 9, 2019

4 checks passed

codecov/patch Coverage not affected when comparing b085af8...b47890d
Details
codecov/project 74.56% (+<.01%) compared to b085af8
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@niden

This comment has been minimized.

Copy link
Member

commented Jun 9, 2019

Thank you @SidRoberts

@niden niden added this to In progress in 4.0 Release via automation Jun 9, 2019

@niden niden added the Enhancement label Jun 9, 2019

@niden niden moved this from In progress to Done in 4.0 Release Jun 9, 2019

@SidRoberts SidRoberts deleted the SidRoberts:micro-handler-array branch Jun 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.