Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T14464 cast on arr collection #14465

Merged
merged 8 commits into from
Oct 13, 2019
Merged

T14464 cast on arr collection #14465

merged 8 commits into from
Oct 13, 2019

Conversation

niden
Copy link
Sponsor Member

@niden niden commented Oct 12, 2019

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Added cast parameter to Phalcon\Collection::get and Phalcon\Helper\Arr::get allowing developers to cast the result returned to the type they want to.

Thanks

@niden niden added 4.0 enhancement Enhancement to the framework labels Oct 12, 2019
@niden
Copy link
Sponsor Member Author

niden commented Oct 12, 2019

cc @ruudboon @sergeyklay

phalcon/Helper/Arr.zep Outdated Show resolved Hide resolved
sergeyklay
sergeyklay previously approved these changes Oct 13, 2019
@codecov
Copy link

codecov bot commented Oct 13, 2019

Codecov Report

Merging #14465 into 4.0.x will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            4.0.x   #14465      +/-   ##
==========================================
- Coverage   67.67%   67.66%   -0.01%     
==========================================
  Files         482      482              
  Lines      111229   111331     +102     
==========================================
+ Hits        75275    75337      +62     
- Misses      35954    35994      +40

@niden
Copy link
Sponsor Member Author

niden commented Oct 13, 2019

@ruudboon settype will return a notice if the wrong type is passed so we are OK on that.

@niden niden merged commit 86ed6b2 into phalcon:4.0.x Oct 13, 2019
@niden niden deleted the T14464-cast-on-arr-collection branch October 22, 2019 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to the framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants