Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T14514 logger transactions #14516

Merged
merged 2 commits into from Nov 6, 2019
Merged

T14514 logger transactions #14516

merged 2 commits into from Nov 6, 2019

Conversation

niden
Copy link
Sponsor Member

@niden niden commented Nov 6, 2019

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Fixed Phalcon\Logger to correctly add transactional logging to any adapter the developer wants.

Thanks

@niden niden added 4.0 labels Nov 6, 2019
@niden niden added this to In progress in 4.0.0 Release via automation Nov 6, 2019
@codecov
Copy link

codecov bot commented Nov 6, 2019

Codecov Report

Merging #14516 into 4.0.x will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            4.0.x   #14516      +/-   ##
==========================================
- Coverage   67.69%   67.69%   -0.01%     
==========================================
  Files         482      482              
  Lines      111763   111775      +12     
==========================================
+ Hits        75663    75670       +7     
- Misses      36100    36105       +5

@niden niden merged commit 36912b2 into phalcon:4.0.x Nov 6, 2019
4.0.0 Release automation moved this from In progress to Done Nov 6, 2019
@niden niden deleted the T14514-logger-transactions branch November 6, 2019 18:53
@niden niden added bug A bug report status: low Low and removed Bug - Low labels Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug report status: low Low
Projects
No open projects
4.0.0 Release
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants