Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T14688 session key unique #14689

Merged
merged 3 commits into from
Jan 6, 2020
Merged

T14688 session key unique #14689

merged 3 commits into from
Jan 6, 2020

Conversation

niden
Copy link
Sponsor Member

@niden niden commented Jan 6, 2020

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Fixed Phalcon\Session\Manager::getUniqueKey to prefix the key only if uniqueId is present

Thanks

@niden niden added 4.0.1 bug A bug report status: medium Medium labels Jan 6, 2020
@niden niden changed the base branch from master to 4.0.x January 6, 2020 20:09
@niden niden self-assigned this Jan 6, 2020
@ruudboon
Copy link
Member

ruudboon commented Jan 6, 2020

Thnx. Looks good to me.

@codecov
Copy link

codecov bot commented Jan 6, 2020

Codecov Report

Merging #14689 into 4.0.x will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            4.0.x   #14689      +/-   ##
==========================================
+ Coverage   67.92%   67.92%   +<.01%     
==========================================
  Files         483      483              
  Lines      111477   111483       +6     
==========================================
+ Hits        75724    75730       +6     
  Misses      35753    35753

@niden niden merged commit 88af141 into phalcon:4.0.x Jan 6, 2020
@niden niden deleted the T14688-session-key-unique branch January 26, 2020 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug report status: medium Medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants