Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete useless test because GetSet exists and add some test for GetSetEventManager. #14740

Merged
merged 5 commits into from
Jan 19, 2020

Conversation

jenovateurs
Copy link
Contributor

Hello!
Delete tests useless and empty.
Add new tests unit.

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Thanks

@codecov
Copy link

codecov bot commented Jan 19, 2020

Codecov Report

Merging #14740 into 4.0.x will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            4.0.x   #14740      +/-   ##
==========================================
+ Coverage   67.97%   67.97%   +<.01%     
==========================================
  Files         483      483              
  Lines      111435   111435              
==========================================
+ Hits        75749    75752       +3     
+ Misses      35686    35683       -3

@ruudboon ruudboon merged commit 584b32c into phalcon:4.0.x Jan 19, 2020
@ruudboon
Copy link
Member

thnx @jenovateurs

@niden niden added 4.0.3 testing Tests related issue labels Jan 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Tests related issue
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants