Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T16471 count orderby #16485

Merged
merged 17 commits into from
Dec 26, 2023
Merged

T16471 count orderby #16485

merged 17 commits into from
Dec 26, 2023

Conversation

niden
Copy link
Sponsor Member

@niden niden commented Dec 26, 2023

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Fixed Phalcon\Mvc\Model::count to ignore the order parameter (needed for Posgresql)

Thanks

@niden niden requested a review from Jeckerson December 26, 2023 19:43
@niden niden self-assigned this Dec 26, 2023
@niden niden linked an issue Dec 26, 2023 that may be closed by this pull request
[BUG]: Phalcon\Paginator\Adapter\Model generates an invalid request with order parameter #16471
Closed
Jeckerson
Jeckerson reviewed Dec 26, 2023
View reviewed changes
phalcon/Mvc/Model.zep Outdated Show resolved Hide resolved
phalcon/Mvc/Model.zep Outdated Show resolved Hide resolved
@niden niden merged commit a98908e into phalcon:5.0.x Dec 26, 2023
34 checks passed
@niden niden deleted the T16471-count-orderby branch December 26, 2023 20:30
@niden niden mentioned this pull request Dec 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees

@niden niden

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Phalcon\Paginator\Adapter\Model generates an invalid request with order parameter
2 participants
@niden @Jeckerson