3.1.1 #751
Merged
3.1.1 #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used latest Phalcon
Fixing #718 : Dialect Oracle not working
Should check each param is is a `\CURLFile` f.e. created via `curl_file_create($file)`.
Example:
$provider = \Phalcon\Http\Client\Request::getProvider();
// POST a file
$file = '/home/mine/myimage.jpg';
$response = $provider->post('me/upload', [
'access_token' => 1234,
'file' => curl_file_create(realpath($file)),
]);
echo $response->header->statusCode;
Reason:
See `CURLOPT_SAFE_UPLOAD` http://php.net/manual/en/function.curl-setopt.php
`Added in PHP 5.5.0 with FALSE as the default value. PHP 5.6.0 changes the default value to TRUE.`
_and disabled with PHP 7_
Curl::initPostFields checks for \CURLFile
* Added ::setOption ::setOptions CURLOPT_XXX alias Addded simple check if given option key is a curlopt_xxx string * Fixed no space found after comma * Fixed no space found after comma
* Fixed lost curl error
Moving __destruct -fix ("release" Curl instance from header function) to bottom -- before return.
* Fixed no space found after comma
* Fixed no space found after comma
* Small cleanup * Be verbose on tests * Cleaned Beanstalk ExtendedTest
fix attempt for Warning: setlocale(): Specified locale name is too long needs to be tested deeper
Fix for: Warning: preg_match() expects parameter 2 to be string, object given Allow a traversable object for the $email parameter for the normalizeEmail function
For nearly six months, the tests are falling regularly. Fork is the only dependence, which is constantly fails tests In the future we will deprecate the Fork Helper in favor of ReactPHP, Promises, etc. Cc: @duncan3dc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.