Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verilog inline #279

Merged
merged 3 commits into from Sep 7, 2018
Merged

Verilog inline #279

merged 3 commits into from Sep 7, 2018

Conversation

rsetaluri
Copy link
Collaborator

Make inlining verilog (through coreir) an option that can be specified.

rdaly525 and others added 2 commits September 6, 2018 23:48
@rdaly525 @rsetaluri
added optional inlining for verilog
a76b492
@rsetaluri
Make coreir-verilog inline a generic option
248c510 
Making inline verilog through coreir an option, rather than its own
compilation target.
@coveralls
Copy link

coveralls commented Sep 7, 2018 •
edited

Pull Request Test Coverage Report for Build 1079

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 70.43%
Changes Missing Coverage Covered Lines Changed/Added Lines %
magma/compile.py 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
magma/compile.py 1 72.62%
Totals Coverage Status
Change from base Build 1072: -0.03%
Covered Lines: 3344
Relevant Lines: 4748
💛 - Coveralls

leonardt
leonardt requested changes Sep 7, 2018
View reviewed changes
magma/compile.py Outdated Show resolved Hide resolved
leonardt
leonardt approved these changes Sep 7, 2018
View reviewed changes
Copy link
Collaborator

@leonardt leonardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@leonardt leonardt merged commit 1c99426 into master Sep 7, 2018
@leonardt leonardt deleted the verilog_inline branch September 7, 2018 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonardt leonardt leonardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rsetaluri @coveralls @leonardt @rdaly525