Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8.0.1 fixes #23 #24

Merged
merged 2 commits into from
Jul 29, 2018
Merged

8.0.1 fixes #23 #24

merged 2 commits into from
Jul 29, 2018

Conversation

Sefriol
Copy link
Contributor

@Sefriol Sefriol commented Jul 20, 2018

Fixes required to make this work in 8.0.1

Key changes to API:

  • BN_FRIEND_TOON_ONLINE: Not supported anymore (?) This causes it not to work.

Attempting to register or unregister for an unknown event will now generate a Lua error

Key changes to UI:

  • Up and Down buttons do not exist anymore and scroll to bottom button name has been changed.

Key changes to GlobalStrings:

  • BN_TOAST_LEFT_OFFSET: Removed (?) therefore the variable is changed it to 1 (which was the original value).

@Sefriol Sefriol mentioned this pull request Jul 20, 2018
Closed
MisatoTremor
MisatoTremor approved these changes Jul 20, 2018
View reviewed changes
Copy link

@MisatoTremor MisatoTremor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works so far

@Phanx
Copy link
Member

Phanx commented Jul 29, 2018

Thanks!

@Phanx Phanx merged commit 63f5f16 into phanx-wow:master Jul 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MisatoTremor MisatoTremor MisatoTremor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sefriol @Phanx @MisatoTremor