-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker (min) #163
base: master
Are you sure you want to change the base?
Add docker (min) #163
Conversation
Hi @theseer, Could you have a look? |
You might call me ignorant, but I fail to see the purpose of this? And the resulting container is still to big: The cleanup is done in a separate If I am to introduce this - again, I'm not sure what the purpose is ;) - it should be a multi stage or minimal runtime container. |
And, what does all this have to do with our website? |
1fd0191
to
47d9c64
Compare
47d9c64
to
7f40ce1
Compare
Hi @theseer It is for local development only not for production. |
May be closing of previous PR is my wrong. And it would be better to have installed http server too. To have opportunity to run site locally and to be able to debug html & css. |
You do realize that this is a 100% static website, right? You can use the IDE build-in preview/webserver to look at things. The only php script included in this repository is the check/sort script you introduced. There is zero need for a webserver, or PHP-FPM. Nobody needs docker or compose. |
Hi @theseer, Ok. Maybe you have worthwhile arguments in your discourse. Feel free to close this PR |
No description provided.