Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker (min) #163

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

Aeliot-Tm
Copy link
Contributor

No description provided.

@Aeliot-Tm Aeliot-Tm mentioned this pull request Sep 9, 2024
@Aeliot-Tm
Copy link
Contributor Author

Hi @theseer,

Could you have a look?

@theseer
Copy link
Member

theseer commented Sep 23, 2024

You might call me ignorant, but I fail to see the purpose of this?

And the resulting container is still to big: The cleanup is done in a separate RUN so it's useless as the previous layer contains all the crap. It still uses debian, which is fat. It still keeps all the artifacts and tooling to compile additional things.

If I am to introduce this - again, I'm not sure what the purpose is ;) - it should be a multi stage or minimal runtime container.

@theseer
Copy link
Member

theseer commented Sep 23, 2024

And, what does all this have to do with our website?

@Aeliot-Tm Aeliot-Tm force-pushed the add-docker-min branch 2 times, most recently from 1fd0191 to 47d9c64 Compare October 27, 2024 17:22
@Aeliot-Tm
Copy link
Contributor Author

Hi @theseer

It is for local development only not for production.
May be you have php installed locally and you like this approach. As for me and many other developer, I don't have it locally. Case it is not comfortable to reinstall it several times a day when work with different projects. So, I'd like to have prepared container with all necessary stuff. As for minimization of container, what should be removed on your point of view? All php-modules described in Docker file should be added, I think.

@Aeliot-Tm
Copy link
Contributor Author

May be closing of previous PR is my wrong. And it would be better to have installed http server too. To have opportunity to run site locally and to be able to debug html & css.

@Aeliot-Tm
Copy link
Contributor Author

Aeliot-Tm commented Oct 27, 2024

As for docker-compose.yml or compose.yml it is necessary for easy configuration of CLI interpreter in PHPStorm (IDE). And to use all power of it. So, developers can add it event docker images are pruned.

image

@theseer
Copy link
Member

theseer commented Oct 27, 2024

You do realize that this is a 100% static website, right? You can use the IDE build-in preview/webserver to look at things.

The only php script included in this repository is the check/sort script you introduced. There is zero need for a webserver, or PHP-FPM. Nobody needs docker or compose.

@Aeliot-Tm
Copy link
Contributor Author

Hi @theseer,

Ok. Maybe you have worthwhile arguments in your discourse. Feel free to close this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants