Fixes PDB file correction for multi-model structures #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For structures with multiple models PLIP discarded all header infos (including the PDB ID). This commit solves the issue.
|
Hi Katja, thanks, happy new year to you, too! Thanks a lot for this contribution! Great work 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Florian, happy new year! :)
I followed up on some issues I noticed and realized that for structures with multiple models, PLIP discards all header info (including the PDB ID) when checking the PDB file for mistakes. The issue causes the [pdbid]_PROTEIN filenames that occur when running PLIP on a structure from the PDB with multiple models. It also prevents PLIP web from correctly linking to the PDB entry of the structure.
This solves the issue.