Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a bug when using --nofix #126

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Fixes a bug when using --nofix #126

merged 1 commit into from
Mar 29, 2022

Conversation

zrt
Copy link
Contributor

@zrt zrt commented Mar 25, 2022

self.protcomplex, self.filetype = read_pdb(self.corrected_pdb, as_string=True)

This line (link ) sets as_string=True, but the self.corrected_pdb may fallback to pdbpath (when use --nofix or PDBParser meets some errors, see link1 and link2 ).

I changed this line to fix this problem.

self.protcomplex, self.filetype = read_pdb(self.corrected_pdb, as_string= (self.corrected_pdb != pdbpath)) 

Thank you.

@zrt zrt changed the base branch from master to development March 25, 2022 12:52
Copy link
Contributor

@fkaiserbio fkaiserbio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@fkaiserbio fkaiserbio merged commit a2223b8 into pharmai:development Mar 29, 2022
@fkaiserbio
Copy link
Contributor

Thanks for this contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants