Testing scavenger tenuring #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are some perm space test failing, are they related? |
I've seen the same tests fail in another PR, I don't think they are related to this one |
- New abstractions - Bye duplicated logic - Classifying
|
Here is a chart with the before and after 🤔
|
|
the dots are the scavenge thresholds? this means that we are periodically wrongly tenuring 2MB of objects in this scenario, right? |
|
also the second graph required 2/3 of the scavenges... |
|
Yes! |
|
The bench of the second graph was shorter (it was in interactive mode), so I don't know the impact on the amount of scavenges. |
|
Thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With @jordanmontt we started to profile the GC activity, especially the Scavenger.
Looking at the code, we realised that the Tenuring algorithm was not tested.
Then we realise that the Scavenger had a bug setting the
tenureThreshold, so the tenuring is not working as expected.In this PR:
tenureThresholdcomputation was fixed (it was setting it in the wrong semi-space)