Missing class side variable after reloading a Trait which used another Trait, from GitHub + image unstability and crashs

[labordep]

Bug description
Class side variable of a Trait is removed after reloading the Trait.
Due to this problem, my Pharo image is unstable and a lot of crashes can appears.
When I'm reloading the package manually, the var is appears! But the system is not stable

The Trait on GitHub (look at anInstanceVariable) :

Trait {
	#name : #MolDirtyType,
	#classInstVars : [
		'anInstanceVariable'
	],
	#traits : 'MolComponentType',
	#classTraits : 'MolComponentType classTrait',
	#category : #'Molecule-Tests-Resources - Contracts'
}

The Trait after loading the project into Pharo :

Look at the red methods which are using anInstanceVariable.

The Trait after re-loading manually the package :


Red methods are always here.


The image is always unstable, var is here but not considered.

To Reproduce
Steps to reproduce the behavior:

1. Create a Trait1
2. Define another Trait2 which uses Trait1
3. Define a class side variable into Trait2
4. Publish the code into GitHub
5. Create a new image
6. Reload the project : the var in Trait2 is missing

The problem is present when loading manually (Add button) or from a baseline script.

About crashes and unstability
The image is unstable at the moment of a Trait1 with a class side var uses a Trait2, or at the moment of we create a class side var in a Trait 1 uses Trait 2.

Expected behavior
Variable should be exists, but missing.

Screenshots
If applicable, add screenshots to help explain your problem.

Version information:

• OS: Windows 11 Pro 64 bits & Windows 10 Pro 64 bits
• Version: Pharo 12 & Pharo 11 & Pharo 10

[jecisc]

There was some updates in loading code in Pharo 12 but if it also happens in Pharo 11 it is probably not related to that. I'll try to find some time next week to look into it since I recently learned more about the code managing loading classes and traits,

[labordep]

Thanks @jecisc :) this problem is impacting our architecture framework at the core of all our applications :(

[Ducasse]

Pierre do I guess correctly that it was working correctly in P10?

[Ducasse]

This is really strange because Moose is heavily using traits and they do not experience this problem so I'm really curious.
May be this is a metaclass level problem.

[labordep]

Pierre do I guess correctly that it was working correctly in P10?

I have tested to load my project in Pharo 10, you can try with this script :

Metacello new
   baseline: 'Molecule';
   repository: 'github://OpenSmock/Molecule:dev-99';
   load.

And this is the same problem :/

And on GitHub :

Very strange! And the commit window is curious because it seams that the system know there is a difference but it cannot show it correctly :

[labordep]

May be Molecule can impact in a way this bug, can you reproduce this problem ?
=> No (see below)

[labordep]

I writted a project to reproduce : https://github.com/labordep/Project14749
Add manually the project with the "Add" button works and my Trait is not yet using another Trait.

GitHub

GitHub - labordep/Project14749: Test project to reproduce issue 14749

Test project to reproduce issue 14749. Contribute to labordep/Project14749 development by creating an account on GitHub.

[labordep]

Ok I reproduced it clearly !

I update my issue, the problem appears when the Trait uses another Trait.
The image was instable and crash at the instant of my Trait (with a class side var) uses another Trait.
I update my issue with this information.

[jecisc]

I found the problem but I do not know yet how to fix it.

The problem is that for traits we have MCTraitDefinition and MCClassTraitDefinition in Monticello.

Things such as class slots and managed by MCTraitDefinition and are installed correctly. But the class trait composition is set by MCClassTraitDefinition afterward and this removes anything else configured in the class side.

I don't understand why we have both those classes and not just one. I need to talk to Pablo to see if we can unify. But anyway, knowing the root of the problem I'll at least be able to produce a workaround.

[jecisc]

So I did a workaround for Pharo 11: #14768

And for Pharo 12 I have a PR on Pharo and a PR on Tonel with a better cleaning and both are passing:
#14766
pharo-vcs/tonel#112

I am now waiting for reviews and this should fix your problem

[labordep]

So I did a workaround for Pharo 11: #14768

And for Pharo 12 I have a PR on Pharo and a PR on Tonel with a better cleaning and both are passing: #14766 pharo-vcs/tonel#112

I am now waiting for reviews and this should fix your problem

Thanks @jecisc! Keep me informed :)

[labordep]

It looks good!
But a lot of crashs :/

[jecisc]

This should also be fixed in Pharo12 tomorrow

[labordep]

This should also be fixed in Pharo12 tomorrow

I have a lot of crashs in P11 :/
Especially when I'm playing with Iceberg, for example to load/view/explore/just select a branch with this specific Trait.

[jecisc]

Note: The crashes are coming from a VM that is too old probably

[jecisc]

@labordep This issue should be fixed in Pharo 12 too now

[labordep]

Note: The crashes are coming from a VM that is too old probably

Thanks @jecisc, I check this problem and if necessary open a new issue.

[labordep]

@jecisc we cannot change the VM because of that : #13726

[labordep]

@jecisc this is ok in the lastest VM from my Home, I haven't crashes 👍 .
At work we need to solve #13726.
Thanks for the fix !