Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Put debugger stack on the left #629

Closed
wants to merge 1 commit into from

Conversation

guillep
Copy link
Contributor

@guillep guillep commented Nov 27, 2023

imagen

@estebanlm
Copy link
Member

estebanlm commented Nov 27, 2023

not against :)

but I am working on the message browser, and I added a "flip" button to allow the user to switch as they please.
I guess it could be the same for the debugger?

EDIT: submitted before finish, fixed :P

@StevenCostiou
Copy link
Member

Following this proposition, I planned to propose a dynamic switch between layouts in the debugger.
Not exactly a flip, more there is a list of layouts some provided by default and if you want you can add yours, and then you select the one that you want in the debugger (from a menu somewhere) and it becomes the new default in your image.

I wanted to do that last friday because it is really trivial to do, but I got sick with kids...

I'll try it tomorrow if I don't have kids on my hands :p

Comment on lines 1138 to 1144
{ #category : 'specs' }
StDebugger >> stackAndCodeLayout [

^ SpPanedLayout newTopToBottom
^ SpPanedLayout newLeftToRight
positionOfSlider: 30 percent;
add: self stackLayout;
add: self codeLayout;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually the only change right?
All the other diffs are just code reformating? (hard to see)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed also the columns.
Having too many columns is good for a vertical layout, where the method list can be very large.
But for the horizontal layout the list should be narrower, so having too many columns is not very good there...
Tradeoffs :)

@StevenCostiou
Copy link
Member

We can close it now, since another PR implementing this change has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants