-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Proposal] Put debugger stack on the left #629
Conversation
guillep
commented
Nov 27, 2023
06d89c9
to
01e6bba
Compare
01e6bba
to
c04720a
Compare
not against :) but I am working on the message browser, and I added a "flip" button to allow the user to switch as they please. EDIT: submitted before finish, fixed :P |
Following this proposition, I planned to propose a dynamic switch between layouts in the debugger. I wanted to do that last friday because it is really trivial to do, but I got sick with kids... I'll try it tomorrow if I don't have kids on my hands :p |
{ #category : 'specs' } | ||
StDebugger >> stackAndCodeLayout [ | ||
|
||
^ SpPanedLayout newTopToBottom | ||
^ SpPanedLayout newLeftToRight | ||
positionOfSlider: 30 percent; | ||
add: self stackLayout; | ||
add: self codeLayout; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually the only change right?
All the other diffs are just code reformating? (hard to see)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed also the columns.
Having too many columns is good for a vertical layout, where the method list can be very large.
But for the horizontal layout the list should be narrower, so having too many columns is not very good there...
Tradeoffs :)
We can close it now, since another PR implementing this change has been merged. |