Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue when opening custom scope on calypso #783

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

carolahp
Copy link
Contributor

@carolahp carolahp commented Jun 17, 2024

Currently user created Scopes (i.e. custom scopes) cannot be browsed in Calypso.
This PR fixes issues related to this functionality.

This is necessary for the proper functioning of PR#16771 in Pharo repo

@carolahp carolahp marked this pull request as ready for review June 17, 2024 23:33
@carolahp
Copy link
Contributor Author

Failing tests do not fail in my local image (I don't understand why)
image

@jecisc
Copy link
Member

jecisc commented Jun 18, 2024

Failing tests are unrelated

Copy link
Member

@jecisc jecisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be nice to add a comment to explain why it is needed but i"ll merge it for now

@jecisc jecisc merged commit 4e589fa into pharo-spec:Pharo13 Jun 18, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants