Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

withWindowDo: should return the result of the block #1555

Merged
merged 3 commits into from
Jun 13, 2024

Conversation

demarey
Copy link
Collaborator

@demarey demarey commented Jun 13, 2024

Else, if you would like to trigger the ok action, you will not get back the result of the actions (e.g. selected item)

@estebanlm
Copy link
Member

indeed

@estebanlm
Copy link
Member

but then... what it returns if there is no window? still answering self sounds weak (I very much prefer nil in this case)

@demarey
Copy link
Collaborator Author

demarey commented Jun 13, 2024

but then... what it returns if there is no window? still answering self sounds weak (I very much prefer nil in this case)

yes, I agree. I will change it to return nil

@Ducasse Ducasse merged commit 6d0b7a3 into pharo-spec:Pharo12 Jun 13, 2024
1 of 2 checks passed
jecisc added a commit that referenced this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants