Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When mdn isn't requested no need to calculate mic #58

Closed
ihudedi opened this issue Aug 27, 2018 · 5 comments
Closed

When mdn isn't requested no need to calculate mic #58

ihudedi opened this issue Aug 27, 2018 · 5 comments
Assignees
@phax
Labels
enhancement
Milestone
4.2.0

Comments

@ihudedi
Copy link

ihudedi commented Aug 27, 2018

Hi Philip,
When working with not mdn you don't need to calculare mic.
Is It redundant?
Thanks,
Itay
@phax phax self-assigned this Aug 27, 2018
@phax
Copy link
Owner

phax commented Aug 27, 2018

Correct, but just a minimal overhead....

@ihudedi
Copy link
Author

ihudedi commented Aug 27, 2018

Adding check for requsetmdn will save the calculation.

@phax
Copy link
Owner

phax commented Aug 27, 2018

I'm not sure if the MIC is really only used if a signed MDN is requested, or else as well. I need to check with the specs.

@ihudedi
Copy link
Author

ihudedi commented Aug 27, 2018 •
edited
Loading

I am talking when not requesting mdn at all then not calculating mic.

phax added a commit that referenced this issue Aug 27, 2018
@phax
Calculate MIC only if MDN is requested; #58
cb13085
@phax phax added this to the 4.2.0 milestone Aug 27, 2018
@phax
Copy link
Owner

phax commented Aug 27, 2018

Done :)

@phax phax closed this as completed Aug 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phax phax

Labels
enhancement
Projects
None yet
Milestone
4.2.0
Development

No branches or pull requests
2 participants
@phax @ihudedi