Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent API in Partnership #6

Closed
jochenberger opened this issue Sep 1, 2015 · 2 comments
Closed

Inconsistent API in Partnership #6

jochenberger opened this issue Sep 1, 2015 · 2 comments

Comments

@jochenberger
Copy link
Collaborator

This is a very minor issue, but it somehow feels strange this way.
Partnership.getAllAttributes() returns IStringMap whereas getAllSenderIDs() and getAllReceiverIDs return StringMap. I'd say they should all return IStringMap.
But maybe the methods should be deprecated altogether and replaced by getters and setters for each property, but I guess that's a separate issue.

@jochenberger
Copy link
Collaborator Author

One more thing:
there's addAllAttributes(IStringMap) but addSenderIDs(Map<String,String>) and addReceiverIDs(Map<String,String>), so different parameter type and different naming scheme.

phax added a commit that referenced this issue Sep 1, 2015
@phax
Copy link
Owner

phax commented Sep 1, 2015

Thanks for pointing that out Jochen. Indeed minor things, but still important :)

@phax phax closed this as completed Sep 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants