You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a very minor issue, but it somehow feels strange this way. Partnership.getAllAttributes() returns IStringMap whereas getAllSenderIDs() and getAllReceiverIDs return StringMap. I'd say they should all return IStringMap.
But maybe the methods should be deprecated altogether and replaced by getters and setters for each property, but I guess that's a separate issue.
The text was updated successfully, but these errors were encountered:
One more thing:
there's addAllAttributes(IStringMap) but addSenderIDs(Map<String,String>) and addReceiverIDs(Map<String,String>), so different parameter type and different naming scheme.
This is a very minor issue, but it somehow feels strange this way.
Partnership.getAllAttributes()
returnsIStringMap
whereasgetAllSenderIDs()
andgetAllReceiverIDs
returnStringMap
. I'd say they should all returnIStringMap
.But maybe the methods should be deprecated altogether and replaced by getters and setters for each property, but I guess that's a separate issue.
The text was updated successfully, but these errors were encountered: