Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#5] Add support for PHP 8.1 #11

Merged
merged 1 commit into from
Nov 21, 2021
Merged

[#5] Add support for PHP 8.1 #11

merged 1 commit into from
Nov 21, 2021

Conversation

kpicaza
Copy link
Member

@kpicaza kpicaza commented Nov 21, 2021

Closes #5

@kpicaza kpicaza added enhancement New feature or request dependencies Pull requests that update a dependency file labels Nov 21, 2021
@codecov
Copy link

codecov bot commented Nov 21, 2021 •
edited
Loading

Codecov Report

Merging #11 (a495b95) into 1.0.x (63e1c90) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              1.0.x      #11   +/-   ##
=========================================
  Coverage     96.66%   96.66%           
  Complexity       17       17           
=========================================
  Files             3        3           
  Lines            60       60           
=========================================
  Hits             58       58           
  Misses            2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63e1c90...a495b95. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Nov 21, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

xserrat
xserrat approved these changes Nov 21, 2021
View reviewed changes
Copy link
Contributor

@xserrat xserrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🥳

@kpicaza kpicaza merged commit 96b7dfb into 1.0.x Nov 21, 2021
@kpicaza kpicaza deleted the issue#5 branch November 21, 2021 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xserrat xserrat xserrat approved these changes

@pcs289 pcs289 Awaiting requested review from pcs289

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[laravel-toggle] Add PHP 8.1 support
2 participants
@kpicaza @xserrat