Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] also settype for object (BC) #65

Merged
merged 1 commit into from
Mar 16, 2017
Merged

[WIP] also settype for object (BC) #65

merged 1 commit into from
Mar 16, 2017

Conversation

schmunk42
Copy link
Contributor

@schmunk42 schmunk42 commented Mar 15, 2017 •
edited
Loading

related to #50

This is just a quick BC-fix.

Maybe we can make the types for settype configurable?

[edit]

Or introduce a new type json instead of object, which is handled more efficiently.

@arisk arisk merged commit c7eb302 into phemellc:master Mar 16, 2017
@arisk
Copy link
Contributor

arisk commented Mar 16, 2017

I like the JSON idea

@schmunk42 schmunk42 mentioned this pull request Mar 16, 2017
Closed
@schmunk42 schmunk42 mentioned this pull request Feb 22, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schmunk42 @arisk