Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow int and null values for fadeOut() and fadeInt() #53

Merged
merged 1 commit into from
Oct 25, 2016

Conversation

holtkamp
Copy link
Contributor

No description provided.

@holtkamp
Copy link
Contributor Author

What branch should PRs be submitted to?

@pocesar
Copy link
Contributor

pocesar commented Oct 25, 2016

alpha-2 is actually 4.0.0, because it doesn't have compatibility with jquery < 3

alpha-1 is 3.0.0 as-is, with somewhat backward compatibility (js wise).

@pocesar pocesar merged commit f22d046 into pheryjs:3.0.0-alpha2 Oct 25, 2016
@pocesar
Copy link
Contributor

pocesar commented Oct 25, 2016

thanks for the PR!

@holtkamp
Copy link
Contributor Author

alpha-1 is 3.0.0 as-is, with somewhat backward compatibility (js wise).

aah, ok, we are not yet on jQuery 3, so should I submit the PR to 3.0.0-alpha-1 as well? Tried comparing against 3.0.0.-alpha-1, that was not a success: #54, please advise, or cherry-pick?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants