Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection box pixel polishing #156

Closed
arouinfar opened this issue Jan 30, 2020 · 5 comments
Closed

Collection box pixel polishing #156

arouinfar opened this issue Jan 30, 2020 · 5 comments

Comments

@arouinfar
Copy link
Contributor

Design meeting 1/30/20

Pixel polishes

  • Move strings above the box
  • Add padding between boxes
  • Larger collection panel
  • Bottom-align ResetAllButton with carousel dots

Self-assigning for mockups

@arouinfar
Copy link
Contributor Author

arouinfar commented Feb 3, 2020

  • Molecule strings match Collection string -- 16 pt bold (Single screen)
  • 15 px padding between bottom of the black boxes and the molecule string below it. (Single & Multiple)
  • Bottom-align ResetAllButton with carousel dots and right-align with Your Molecules panel (same position on all 3 screens).
    image

@Denz1994
Copy link
Contributor

Denz1994 commented Feb 4, 2020

Adjustments have been made as specified above in this comment. Can you review this dev version @arouinfar?

@arouinfar
Copy link
Contributor Author

@Denz1994 this is definitely a nice improvement. A few more minor things:

  • It looks like the ResetAllButton is still bottom-aligned with the carousel body instead of its dots, so things are currently pretty tight on the Single screen.

  • On the Multiple screen, the You have: {{#}} string is being obscured a bit by the black box. This is most noticeable when the boxes are empty (bottom of p and y get cut off).
    image

@Denz1994
Copy link
Contributor

The above changes have been applied to Master. The bottom of the resetAllButton is aligned with the bottom of the page control buttons (not the top). Also, there was a spacing added to the CollectionBoxNode VBox options so the box's edge doesn't overlap its label text.

Could you review @arouinfar?

@Denz1994 Denz1994 assigned arouinfar and unassigned Denz1994 Feb 10, 2020
@arouinfar
Copy link
Contributor Author

Looks good @Denz1994, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants