-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can we retain any sort of asset file for the fullNuclideChart.png
image?
#180
Comments
While looking over this, I made a small refactor with the full chart push button. I also updated the notes. I'm not sure how the background became white, for reproducibility, it may be nice to note that @Luisav1. Can you finish this one off? |
On hold until #168 is ready. |
Talking with @zepumph, taking this off-hold since we only need to update the license to match necessary steps to have the current screenshot (even though the link's chart colors would eventually match). |
Updated license.json to include details to get current screenshot. Closing. |
From code review, see #165.
There is an item in the code review checklist that says, "Is there a file in assets/ for every resource file in sound/ and images/?" There isn't such an asset file for
fullNuclideChart.png
, but this may well be a case where it isn't possible to have one. @Luisav1 - The license file entry for this image says, "unmodified screenshot of project created by Luisa Vargas". Is there any other sort of asset that we should retain if we ever wanted to, so, produce a higher-res version of this image? If not, can you enhance the note to say how it could be recreated if necessary?The text was updated successfully, but these errors were encountered: