Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type inference in ToggleNode #201

Closed
samreid opened this issue May 13, 2023 · 1 comment
Closed

Type inference in ToggleNode #201

samreid opened this issue May 13, 2023 · 1 comment

Comments

@samreid
Copy link
Member

samreid commented May 13, 2023

From todos in #170. Type inference not working as expected. Maybe try a newer version of TypeScript?
samreid added a commit that referenced this issue May 13, 2023
@samreid
Move TODOs, see #170 and #201
2c0ada5
@zepumph zepumph mentioned this issue May 19, 2023
Closed
@zepumph
Copy link
Member

zepumph commented May 19, 2023

We are ready to close this issue, all TODOs have been handled, see phetsims/sun#846 (comment)

@zepumph zepumph closed this as completed May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samreid @zepumph