Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TypeScript lint rule: "member-delimiter-style" #1210

Closed
zepumph opened this issue Mar 23, 2022 · 2 comments
Closed

Add TypeScript lint rule: "member-delimiter-style" #1210

zepumph opened this issue Mar 23, 2022 · 2 comments
Assignees
@zepumph
Labels
dev:typescript status:ready-for-review

Comments

@zepumph
Copy link
Member

zepumph commented Mar 23, 2022

Tagging #1114 and phetsims/ratio-and-proportion#405.

This seems like an obvious and easy one to add (we have talked about it before in a dev meeting too). The 630+ errors can be auto fixed. Commits coming soon.
zepumph added a commit to phetsims/circuit-construction-kit-common that referenced this issue Mar 23, 2022
@zepumph
add member-delimiter-style lint rule (semi colons after member declar…
5d939da 
…ations in types). phetsims/chipper#1210
zepumph added a commit to phetsims/density-buoyancy-common that referenced this issue Mar 23, 2022
@zepumph
add member-delimiter-style lint rule (semi colons after member declar…
bae270e 
…ations in types). phetsims/chipper#1210
zepumph added a commit to phetsims/center-and-variability that referenced this issue Mar 23, 2022
@zepumph
add member-delimiter-style lint rule (semi colons after member declar…
fd5b2cf 
…ations in types). phetsims/chipper#1210
zepumph added a commit to phetsims/ratio-and-proportion that referenced this issue Mar 23, 2022
@zepumph
add member-delimiter-style lint rule (semi colons after member declar…
f525961 
…ations in types). phetsims/chipper#1210
zepumph added a commit to phetsims/gravity-and-orbits that referenced this issue Mar 23, 2022
@zepumph
add member-delimiter-style lint rule (semi colons after member declar…
617b389 
…ations in types). phetsims/chipper#1210
zepumph added a commit to phetsims/greenhouse-effect that referenced this issue Mar 23, 2022
@zepumph
add member-delimiter-style lint rule (semi colons after member declar…
f8a82d4 
…ations in types). phetsims/chipper#1210
zepumph added a commit to phetsims/utterance-queue that referenced this issue Mar 23, 2022
@zepumph
add member-delimiter-style lint rule (semi colons after member declar…
feba830 
…ations in types). phetsims/chipper#1210
zepumph added a commit to phetsims/counting-common that referenced this issue Mar 23, 2022
@zepumph
add member-delimiter-style lint rule (semi colons after member declar…
391b182 
…ations in types). phetsims/chipper#1210
zepumph added a commit to phetsims/build-a-nucleus that referenced this issue Mar 23, 2022
@zepumph
add member-delimiter-style lint rule (semi colons after member declar…
a79b489 
…ations in types). phetsims/chipper#1210
zepumph added a commit to phetsims/quadrilateral that referenced this issue Mar 23, 2022
@zepumph
add member-delimiter-style lint rule (semi colons after member declar…
448c9e9 
…ations in types). phetsims/chipper#1210
zepumph added a commit to phetsims/bending-light that referenced this issue Mar 23, 2022
@zepumph
add member-delimiter-style lint rule (semi colons after member declar…
1a49c52 
…ations in types). phetsims/chipper#1210
zepumph added a commit to phetsims/scenery-phet that referenced this issue Mar 23, 2022
@zepumph
add member-delimiter-style lint rule (semi colons after member declar…
c9a0813 
…ations in types). phetsims/chipper#1210
zepumph added a commit to phetsims/number-play that referenced this issue Mar 23, 2022
@zepumph
add member-delimiter-style lint rule (semi colons after member declar…
4f18f87 
…ations in types). phetsims/chipper#1210
zepumph added a commit to phetsims/phet-core that referenced this issue Mar 23, 2022
@zepumph
add member-delimiter-style lint rule (semi colons after member declar…
8cda705 
…ations in types). phetsims/chipper#1210
zepumph added a commit to phetsims/tangible that referenced this issue Mar 23, 2022
@zepumph
add member-delimiter-style lint rule (semi colons after member declar…
12ea074 
…ations in types). phetsims/chipper#1210
zepumph added a commit that referenced this issue Mar 23, 2022
@zepumph
add member-delimiter-style lint rule (semi colons after member declar…
871e136 
…ations in types). #1210
zepumph added a commit to phetsims/scenery that referenced this issue Mar 23, 2022
@zepumph
add member-delimiter-style lint rule (semi colons after member declar…
1445110 
…ations in types). phetsims/chipper#1210
zepumph added a commit to phetsims/tandem that referenced this issue Mar 23, 2022
@zepumph
add member-delimiter-style lint rule (semi colons after member declar…
264f9eb 
…ations in types). phetsims/chipper#1210
zepumph added a commit to phetsims/wilder that referenced this issue Mar 23, 2022
@zepumph
add member-delimiter-style lint rule (semi colons after member declar…
6ec4934 
…ations in types). phetsims/chipper#1210
zepumph added a commit to phetsims/joist that referenced this issue Mar 23, 2022
@zepumph
add member-delimiter-style lint rule (semi colons after member declar…
c23a5e7 
…ations in types). phetsims/chipper#1210
zepumph added a commit to phetsims/tambo that referenced this issue Mar 23, 2022
@zepumph
add member-delimiter-style lint rule (semi colons after member declar…
f2dbe97 
…ations in types). phetsims/chipper#1210
zepumph added a commit to phetsims/vegas that referenced this issue Mar 23, 2022
@zepumph
add member-delimiter-style lint rule (semi colons after member declar…
e17f87a 
…ations in types). phetsims/chipper#1210
zepumph added a commit to phetsims/kite that referenced this issue Mar 23, 2022
@zepumph
add member-delimiter-style lint rule (semi colons after member declar…
5a4334f 
…ations in types). phetsims/chipper#1210
zepumph added a commit to phetsims/axon that referenced this issue Mar 23, 2022
@zepumph
add member-delimiter-style lint rule (semi colons after member declar…
c3fd20c 
…ations in types). phetsims/chipper#1210
zepumph added a commit to phetsims/sun that referenced this issue Mar 23, 2022
@zepumph
add member-delimiter-style lint rule (semi colons after member declar…
e9d0749 
…ations in types). phetsims/chipper#1210
zepumph added a commit to phetsims/dot that referenced this issue Mar 23, 2022
@zepumph
add member-delimiter-style lint rule (semi colons after member declar…
4da4456 
…ations in types). phetsims/chipper#1210
samreid pushed a commit to phetsims/scenery-phet that referenced this issue Apr 9, 2022
@zepumph
add member-delimiter-style lint rule (semi colons after member declar…
b28f026 
…ations in types). phetsims/chipper#1210
samreid pushed a commit to phetsims/scenery-phet that referenced this issue Apr 15, 2022
@zepumph
add member-delimiter-style lint rule (semi colons after member declar…
e47ee48 
…ations in types). phetsims/chipper#1210
@pixelzoom
Copy link
Contributor

We had concensus on this in a dev meeeting, and it looks like this has been enabled for 3+ weeks. @zepumph can this be closed?

@zepumph
Copy link
Member Author

zepumph commented Apr 18, 2022

Yes please. Thanks

@zepumph zepumph closed this as completed Apr 18, 2022
zepumph added a commit to phetsims/perennial that referenced this issue Oct 22, 2024
@zepumph
add member-delimiter-style lint rule (semi colons after member declar…
24633f0 
…ations in types). phetsims/chipper#1210
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepumph zepumph

Labels
dev:typescript status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pixelzoom @zepumph