Stricter tsconfig and lint for some TypeScript repos

[pixelzoom]

I'm responsible for a growing number of sims and common-code repos that have been converted to TypeScript. Most of them are very clean and exceed the requirements of chipper/eslint/sim_eslintrc.js. and I'd like to keep it that way.

TODO:

(1) Identify what to make stricter, and whether that should be done via tsconfig.json or package.json "eslintConfig".

(2) Identify the correct pattern to use in package.json "eslintConfig". I see this being done in 2 different ways, and I'm not sure if they are correct/equivalent. For example, I added this override to geometric-optics/package.json to prevent // @ts- comments:

"eslintConfig": {
    "extends": "../chipper/eslint/sim_eslintrc.js",
    "overrides": [
      {
        "files": [
          "**/*.ts"
        ],
        "rules": {
          "@typescript-eslint/ban-ts-comment": "error"
        }
      }
    ]
  }

But @zepumph recently added this override to a number of repos to opt-out of "todo-should-have-issue". It's less verbose, but is this also effectively an override? Why is it not in the "eslintConfig.overrides" section?

  "eslintConfig": {
    "extends": "../chipper/eslint/sim_eslintrc.js",
    "rules": {
      "todo-should-have-issue": "off"
    }
  }

[pixelzoom]

... I see this being done in 2 different ways, and I'm not sure if they are correct/equivalent.

I tested and they are equivalent. So in the above commit, I've replaced "eslintConfig.override.rules" with the simpler "eslintConfig.rules" form.

[pixelzoom]

In the above commits, I moved all TypeScript rules to eslintConfig.overrides.rules in package.json, as recommended by @zepumph. I did this for all repos where it was relevant.

Closing.