Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a11y view HTML template should have the iframe scroll with you as you look at the pDOM #617

Closed
zepumph opened this issue Nov 3, 2017 · 6 comments
Closed

a11y view HTML template should have the iframe scroll with you as you look at the pDOM #617

zepumph opened this issue Nov 3, 2017 · 6 comments
Assignees
@zepumph
Labels
status:on-hold

Comments

@zepumph
Copy link
Member

zepumph commented Nov 3, 2017

No description provided.

@zepumph zepumph self-assigned this Nov 3, 2017
zepumph added a commit to phetsims/reactants-products-and-leftovers that referenced this issue Nov 3, 2017
@zepumph
update a11y view to iframe scroll, phetsims/chipper#617
081c1cd
zepumph added a commit to phetsims/balloons-and-static-electricity that referenced this issue Nov 3, 2017
@zepumph
update a11y view to iframe scroll, phetsims/chipper#617
2eefcfe
zepumph added a commit to phetsims/rutherford-scattering that referenced this issue Nov 3, 2017
@zepumph
update a11y view to iframe scroll, phetsims/chipper#617
c98de25
zepumph added a commit to phetsims/resistance-in-a-wire that referenced this issue Nov 3, 2017
@zepumph
update a11y view to iframe scroll, phetsims/chipper#617
562013c
zepumph added a commit to phetsims/molecules-and-light that referenced this issue Nov 3, 2017
@zepumph
update a11y view to iframe scroll, phetsims/chipper#617
676a9ad
zepumph added a commit to phetsims/plinko-probability that referenced this issue Nov 3, 2017
@zepumph
update a11y view to iframe scroll, phetsims/chipper#617
6263058
zepumph added a commit to phetsims/john-travoltage that referenced this issue Nov 3, 2017
@zepumph
update a11y view to iframe scroll, phetsims/chipper#617
6a059f9
@zepumph zepumph assigned jessegreenberg and unassigned zepumph Nov 3, 2017
@zepumph
Copy link
Member Author

zepumph commented Nov 3, 2017

@jessegreenberg could you please review by using an a11y view from master in a few browsers and seeing how you like the new feature?

zepumph added a commit to phetsims/build-an-atom that referenced this issue Nov 3, 2017
@zepumph
update a11y view to iframe scroll, phetsims/chipper#617
9304823
zepumph added a commit to phetsims/coulombs-law that referenced this issue Nov 3, 2017
@zepumph
update a11y view to iframe scroll, phetsims/chipper#617
7bfa5f3
zepumph added a commit to phetsims/friction that referenced this issue Nov 3, 2017
@zepumph
update a11y view to iframe scroll, phetsims/chipper#617
1732570
zepumph added a commit to phetsims/ohms-law that referenced this issue Nov 3, 2017
@zepumph
update a11y view to iframe scroll, phetsims/chipper#617
bf65004
zepumph added a commit to phetsims/molarity that referenced this issue Nov 3, 2017
@zepumph
update a11y view to iframe scroll, phetsims/chipper#617
0e5cbcd
zepumph added a commit that referenced this issue Nov 3, 2017
@zepumph
update a11y view template to scroll iframe with page, #617
dbe1af1
@jessegreenberg
Copy link
Contributor

@zepumph great idea, this is really cool, thank you! This is going to be really nice in development testing and presentations.

Working great in FF and Chrome, but IE, Edge and Safari don't support classList.replace(). Wondering if we can implement that ourselves?

zepumph added a commit to phetsims/reactants-products-and-leftovers that referenced this issue Nov 3, 2017
@zepumph
classList replace --> add/remove, phetsims/chipper#617
0e96df7
zepumph added a commit to phetsims/balloons-and-static-electricity that referenced this issue Nov 3, 2017
@zepumph
classList replace --> add/remove, phetsims/chipper#617
16cf0db
zepumph added a commit to phetsims/rutherford-scattering that referenced this issue Nov 3, 2017
@zepumph
classList replace --> add/remove, phetsims/chipper#617
f224366
zepumph added a commit to phetsims/resistance-in-a-wire that referenced this issue Nov 3, 2017
@zepumph
classList replace --> add/remove, phetsims/chipper#617
0f8621c
zepumph added a commit to phetsims/molecules-and-light that referenced this issue Nov 3, 2017
@zepumph
classList replace --> add/remove, phetsims/chipper#617
ecc0e71
zepumph added a commit to phetsims/plinko-probability that referenced this issue Nov 3, 2017
@zepumph
classList replace --> add/remove, phetsims/chipper#617
75d13a1
zepumph added a commit to phetsims/john-travoltage that referenced this issue Nov 3, 2017
@zepumph
classList replace --> add/remove, phetsims/chipper#617
9ca2bd8
zepumph added a commit to phetsims/build-an-atom that referenced this issue Nov 3, 2017
@zepumph
classList replace --> add/remove, phetsims/chipper#617
24e5aeb
zepumph added a commit to phetsims/coulombs-law that referenced this issue Nov 3, 2017
@zepumph
classList replace --> add/remove, phetsims/chipper#617
c7c66e4
zepumph added a commit to phetsims/friction that referenced this issue Nov 3, 2017
@zepumph
classList replace --> add/remove, phetsims/chipper#617
c6afb8e
zepumph added a commit to phetsims/ohms-law that referenced this issue Nov 3, 2017
@zepumph
classList replace --> add/remove, phetsims/chipper#617
0421012
zepumph added a commit to phetsims/molarity that referenced this issue Nov 3, 2017
@zepumph
classList replace --> add/remove, phetsims/chipper#617
73229d7
zepumph added a commit that referenced this issue Nov 3, 2017
@zepumph
classList replace --> add/remove, #617
3cc2e5d
@zepumph
Copy link
Member Author

zepumph commented Nov 3, 2017

Arg good catch! Anything else?

@zepumph zepumph removed their assignment Nov 3, 2017
@jessegreenberg
Copy link
Contributor

@zepumph its working great in IE11, Edge, Chrome, Firefox, and Safari! I have been using this a bunch already this week, it has been very nice. Closing.

@zepumph
Copy link
Member Author

zepumph commented Nov 18, 2017

Note that this solution doesn't work well on IE, it get's stuck in the scroll view when you scroll back to the top. Leaving open and on hold depending on how phetsims/a11y-research#63 goes.

@zepumph zepumph assigned zepumph and unassigned jessegreenberg Nov 18, 2017
@zepumph zepumph reopened this Nov 18, 2017
@zepumph zepumph mentioned this issue Nov 18, 2017
Closed
@zepumph zepumph mentioned this issue Mar 6, 2018
Closed
8 tasks
@zepumph
Copy link
Member Author

zepumph commented Mar 7, 2018

in phetsims/a11y-research#66 I ditched this method and now have the left column fixed (like phet-io studio). It works well, and I hope we don't have to go back to this approach. Closing

@zepumph zepumph closed this as completed Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepumph zepumph

Labels
status:on-hold
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jessegreenberg @zepumph