Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all of accordion panel is clickable #195

Closed
liammulh opened this issue Jan 20, 2021 · 4 comments
Closed

Not all of accordion panel is clickable #195

liammulh opened this issue Jan 20, 2021 · 4 comments
Labels
type:bug Something isn't working

Comments

@liammulh
Copy link
Member

liammulh commented Jan 20, 2021

Test Device

MacBook Air

Operating System

macOS 10.15.7

Browser

Chrome 87.0.4280.141

Problem Description

For phetsims/qa#599. I think sims normally have the whole panel clickable. See the gifs below.

Visuals

In Collision Lab:
cl

In Published Gas Properties:
gp

Troubleshooting Information

!!!!! DO NOT EDIT !!!!!
Name: ‪Collision Lab‬
URL: https://phet-dev.colorado.edu/html/collision-lab/1.1.0-rc.1/phet/collision-lab_en_phet.html
Version: 1.1.0-rc.1 2021-01-20 01:05:28 UTC
Features missing: applicationcache, applicationcache, touch
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/87.0.4280.141 Safari/537.36
Language: en-US
Window: 1200x777
Pixel Ratio: 1/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 15 uniform: 1024
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 80)
Max viewport: 16384x16384
OES_texture_float: true
Dependencies JSON: {}

@liammulh liammulh added the type:bug Something isn't working label Jan 20, 2021
@arouinfar
Copy link
Contributor

Nice find @muedli!

This looks like an issue in sun. If I open GasProps in master, the only way to open/close the AccordionBox is by clicking on the ExpandCollapseButton.

@zepumph
Copy link
Member

zepumph commented Jan 21, 2021

Noting that this is likely the same as phetsims/ratio-and-proportion#88. I'll promote to a common-code issue.

@jonathanolson
Copy link
Contributor

This should have been fixed in master and on the branch, marking for QA verification.

@DevonQui
Copy link

DevonQui commented Feb 8, 2021

This has been fixed. In all four sections of the simulation, the user is able to click anywhere on the accordion panels to open them. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants