Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sounds missing when jumping to min/max for "Loops" spinner. #193

Closed
pixelzoom opened this issue Jul 16, 2024 · 2 comments
Closed

Sounds missing when jumping to min/max for "Loops" spinner. #193

pixelzoom opened this issue Jul 16, 2024 · 2 comments
Assignees
@Nancy-Salpepi
Labels
dev:a11y status:ready-for-review type:bug Something isn't working

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Jul 16, 2024 •
edited
Loading

For phetsims/sun#886.

Reported in phetsims/sun#886 (comment)

Until phetsims/sun#886 is addressed, I'll need to use the same workaround as phetsims/gas-properties#281 (comment).
@pixelzoom pixelzoom added type:bug Something isn't working dev:a11y labels Jul 16, 2024
@pixelzoom pixelzoom self-assigned this Jul 16, 2024
@pixelzoom pixelzoom mentioned this issue Jul 16, 2024
Closed
pixelzoom added a commit that referenced this issue Jul 16, 2024
@pixelzoom
workaround for 'Loops' spinner Home/End sounds, #193, phetsims/sun#886
a72fdd1
@pixelzoom
Copy link
Contributor Author

@Nancy-Salpepi please test in main, close if OK. As with phetsims/gas-properties#281 (comment), note that you will hear Home/End sounds even if you're already at min/max, due to limitations of the workaround.

@pixelzoom pixelzoom assigned Nancy-Salpepi and unassigned pixelzoom Jul 16, 2024
@Nancy-Salpepi
Copy link

Sounds good in main.
Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nancy-Salpepi Nancy-Salpepi

Labels
dev:a11y status:ready-for-review type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pixelzoom @Nancy-Salpepi