Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge case when magnet at center #148

Closed
zepumph opened this issue Dec 12, 2018 · 2 comments
Closed

Edge case when magnet at center #148

zepumph opened this issue Dec 12, 2018 · 2 comments

Comments

@zepumph
Copy link
Member

zepumph commented Dec 12, 2018

I was playing with the really cool keyboard nav just now (it works very well I think). I found a bit of an edge case. Perhaps the "center" definition varies for the magnet projected on the edge and the directional arrows.

image

I know that this sim isn't in active a11y development but I figured I'd still log the issue. @mbarlow12 over to you. Please feel free to just unassign yourself, but I wanted you to have a look in case it was an easy or duplicated issue, since potentially you are still freshish on the stuff.

@mbarlow12
Copy link
Contributor

Sorry for getting to this so late, and thanks for pointing it out. There was a small discrepancy in the magnet position checks between the jump listener and arrow node displays. Fixed and ready for review.

@zepumph
Copy link
Member Author

zepumph commented Jan 14, 2019

Not a worry, it looks good.

@zepumph zepumph closed this as completed Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants