Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

direction object responses needed for mouse/touch interaction #212

Closed
zepumph opened this issue Aug 11, 2021 · 7 comments
Closed

direction object responses needed for mouse/touch interaction #212

zepumph opened this issue Aug 11, 2021 · 7 comments
Assignees

Comments

@zepumph
Copy link
Member

zepumph commented Aug 11, 2021

Currently, it looks like the BookMovementDescriber is only set up to work with PDOM/keyboard interaction. We need to make sure it get's working for mouse/touch too

@zepumph zepumph self-assigned this Aug 11, 2021
@zepumph
Copy link
Member Author

zepumph commented Aug 11, 2021

I tried to do this patch, but it gave the PDOM too many movement alerts:

Index: js/friction/view/FrictionDragListener.js
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/js/friction/view/FrictionDragListener.js b/js/friction/view/FrictionDragListener.js
--- a/js/friction/view/FrictionDragListener.js	(revision ae2f4a941a4c130a4f53323f0b72e4a7fb5656b3)
+++ b/js/friction/view/FrictionDragListener.js	(date 1628723941204)
@@ -50,6 +50,8 @@
         const vector = new Vector2( delta.x, delta.y );
 
         model.move( vector );
+
+        bookMovementDescriber.endDrag();
       },
       end: () => {
         model.bottomOffsetProperty.set( 0 );
@@ -59,7 +61,6 @@
 
         // pdom
         temperatureIncreasingDescriber.endDrag();
-        bookMovementDescriber.endDrag();
       },
       tandem: tandem
     } );

@zepumph
Copy link
Member Author

zepumph commented Aug 18, 2021

Currently, it looks like the BookMovementDescriber is only set up to work with PDOM/keyboard interaction. We need to make sure it get's working for mouse/touch too

This was not really true, we do still get voicing responses, but only after releasing. We should decide when we want to hear these, because if we keep them the way they are now, "Released" overwrites it completely, and we never hear alerts like:
"At top. Move down to rub harder." or "left".

Assigning to designers:

Is it enough to just hear a single response each time you release the book?

zepumph added a commit to phetsims/utterance-queue that referenced this issue Aug 18, 2021
zepumph added a commit to phetsims/scenery-phet that referenced this issue Aug 18, 2021
@zepumph
Copy link
Member Author

zepumph commented Aug 18, 2021

Oh, one more question. Above, I thought it would sound much better to make the "Released" alert not interrupt, otherwise we don't get any object responses. I would like to discuss and confirm this behavior.

@zepumph
Copy link
Member Author

zepumph commented Aug 25, 2021

Marking for meeting to go over together the two above questions.

@zepumph
Copy link
Member Author

zepumph commented Aug 27, 2021

We discussed during today's meeting. We are fine with the current implementation based on endDrag, and the released not interrupting.

Over to @Matthew-Moore240 to review the implementation with the current version of the sim to see if it works.

https://phet-dev.colorado.edu/html/friction/1.6.0-dev.11/phet/friction_en_phet.html?voicingInitiallyEnabled

@Matthew-Moore240
Copy link

Matthew-Moore240 commented Sep 2, 2021

With the keyboard, the "at top" "left" sound pretty good. On the mouse, the responses seem to bunch up and you hear "left" at the very end and it just sounds pointless. It could be best to just remove the directions altogether.

@zepumph
Copy link
Member Author

zepumph commented Sep 3, 2021

On the mouse, the responses seem to bunch up and you hear "left" at the very end and it just sounds pointless.

This will be fixed over in #224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants