Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mouse interaction alerts cannot run on endDrag #233

Closed
zepumph opened this issue Sep 17, 2021 · 6 comments
Closed

Mouse interaction alerts cannot run on endDrag #233

zepumph opened this issue Sep 17, 2021 · 6 comments
Assignees

Comments

@zepumph
Copy link
Member

zepumph commented Sep 17, 2021

From #231 (comment), we need to update FrictionDragListener so that we don't wait until endDrag to alert. Let's prototype with trying to do it every X drags. Otherwise we may just have to use the Utterance timing variables for this, but I don't see it as a good fit.

@zepumph zepumph self-assigned this Sep 17, 2021
@zepumph
Copy link
Member Author

zepumph commented Sep 17, 2021

From that comment:

I never hear the move-down hint, even when rubbing back and forth several times and I do not bring the books together.

  • This never works, even when releasing to trigger endDrag, likely because it got interrupted with grabbed/release logic. Let's make sure whatever the new solution is has this working.

@zepumph
Copy link
Member Author

zepumph commented Sep 24, 2021

I have potentially fixed this with two items.

  1. I made it much more explicit when you get the "move down to rub harder" alert. It is solely based on the model contactProperty, and not based on the interaction.
  2. I made the timing of alerts for hints and border alerts be based on timing, instead of just the position when you end the drag (let go with the mouse). So instead it will attempt to alert every 3 seconds while dragging. I can change that number, but 4 felt too slow to response, and 2 felt too often.

Please review, and let me know if you want to talk through this. This is only on master right now, not on dev.15

@terracoda
Copy link
Contributor

This sounds pretty good.

@terracoda
Copy link
Contributor

@Matthew-Moore240 and @terracoda discussed, and we feel it would be better if there was some movement (some interaction) before you get move down to rub harder.

That said, if movement and space simultaneously are hard to detect we can live with it as is.

The main idea of the response is that it indicates unproductive rubbing. Having it fire with just air space seems a little extra directive, but not terrible.

@Matthew-Moore240
Copy link

@terracoda @zepumph and @Matthew-Moore240 Reviewed this together and decided to leave it as is. Closing.

@zepumph
Copy link
Member Author

zepumph commented Oct 5, 2021

30ad85b doesn't seem to cut it to me. I was reviewing this code over in #242 (comment) and think it needs to be reworked. It will be done over in #253 where Utterance timing variables will be used instead of in house counting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants