Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Punctuation troubles #250

Closed
zepumph opened this issue Sep 29, 2021 · 1 comment
Closed

Punctuation troubles #250

zepumph opened this issue Sep 29, 2021 · 1 comment
Assignees

Comments

@zepumph
Copy link
Member

zepumph commented Sep 29, 2021

I keep seeying this, but I think I need this issue to remind myself. Almost all of this is about having object responses having punctuation in them, because the responseCollector add punctuation for those anyways. Here is a great example:

zoomed-in Chemistry book, Grabbed. ,
Chemistry book, Grabbed. Lightly on Physics book.,

@zepumph
Copy link
Member Author

zepumph commented Sep 30, 2021

I thought that I needed to mess with punctuation of the alerts, but I actually think that phetsims/scenery#1292 fixed everything I was noting here. @terracoda or @Matthew-Moore240, if you see any other weird punctuation or capitalization in friction as we move towards the finish line, will you please let me know by created a separate issue. Thanks!

@zepumph zepumph closed this as completed Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant