Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ResponsePatternCollection string bug fixes #1292

Closed
zepumph opened this issue Sep 30, 2021 · 2 comments
Closed

ResponsePatternCollection string bug fixes #1292

zepumph opened this issue Sep 30, 2021 · 2 comments
Assignees
@jessegreenberg
Labels
status:ready-for-review

Comments

@zepumph
Copy link
Member

zepumph commented Sep 30, 2021

While working on phetsims/friction#250, I found that two of the default ResponsePatternCollection strings seem wrong to me by a bit:

  nameObject: '{{NAME}}, {{OBJECT}}, ',
  object: '{{OBJECT}} ',

In my opinion, these should not end with a space or comma.
@zepumph zepumph self-assigned this Sep 30, 2021
zepumph added a commit to phetsims/utterance-queue that referenced this issue Sep 30, 2021
@zepumph
minor string pattern bug fix, phetsims/scenery#1292
1dd1439
@zepumph
Copy link
Member Author

zepumph commented Sep 30, 2021

@jessegreenberg, does that seem right to you?

@zepumph zepumph assigned jessegreenberg and unassigned zepumph Sep 30, 2021
@zepumph zepumph mentioned this issue Sep 30, 2021
Closed
@jessegreenberg
Copy link
Contributor

Thanks, I agree and your change looks correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessegreenberg jessegreenberg

Labels
status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jessegreenberg @zepumph