Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhET-iO guide does not exist #316

Closed
KatieWoe opened this issue Jan 2, 2023 · 2 comments
Closed

PhET-iO guide does not exist #316

KatieWoe opened this issue Jan 2, 2023 · 2 comments
Assignees
Labels

Comments

@KatieWoe
Copy link
Contributor

KatieWoe commented Jan 2, 2023

Device
Samsung
OS
Win 11
Browser
Chrome
Problem Description
For phetsims/qa#868
The link to the PhET-iO Guide leads to a 404 error.

@zepumph
Copy link
Member

zepumph commented Jan 4, 2023

Thanks! There was an assumption that you needed an entry in phet-io-sim-specific to get a client guide, but now that is a generated and general resource for all sims, so I updated it so that you don't need a folder in phet-io-sim-specific to get that doc. This is the first sim of the new paradigm. While I was there I also simplified some elements in the process. This is cleanup that probably should have happened around the GAO publication process, but we didn't make the time for it. Now examples are in top level of each sim dir, and that is the only sim-specific file, since we don't need sim-specific images as far as I know.

zepumph added a commit to phetsims/chipper that referenced this issue Jan 4, 2023
zepumph added a commit to phetsims/chipper that referenced this issue Jan 4, 2023
zepumph added a commit to phetsims/chipper that referenced this issue Jan 4, 2023
@zepumph
Copy link
Member

zepumph commented Jan 4, 2023

I discussed with @arouinfar and we agree about the current state of creating and maintaining client guides, I updated the README accordingly. I confirmed that friction is getting a phet-io guide now and has examples (the file and a row in the index). Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants