Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-shown dialog has incorrect position if window size changed #362

Closed
jonathanolson opened this issue Oct 18, 2016 · 2 comments
Closed

Re-shown dialog has incorrect position if window size changed #362

jonathanolson opened this issue Oct 18, 2016 · 2 comments
Assignees
@jonathanolson

Comments

@jonathanolson
Copy link
Contributor

To reproduce:

  1. Open a sim with a dialog that is saved and re-shown (curve-fitting, make-a-ten, etc.)
  2. Open the dialog (from a help/info button)
  3. Close the dialog
  4. Resize the window
  5. Open the dialog

The dialog is now incorrectly repositioned.

Example:
joist-dialog-position
@jonathanolson jonathanolson self-assigned this Oct 18, 2016
jonathanolson added a commit that referenced this issue Oct 18, 2016
@jonathanolson
Update the dialog layout on re-show, in case the layout has changed. …
f02701e 
…See #362
@jonathanolson
Copy link
Contributor Author

Fixed.

@samreid
Copy link
Member

samreid commented Apr 12, 2019

In phetsims/axon#222 we'll be converting this to a strategy that uses Property and multilink instead of Emitter and addListener. I tested the steps above and found that Property/multilink has the correct behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonathanolson jonathanolson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonathanolson @samreid