Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IE11] Splash appears in the top left of the screen at startup, then centers #408

Closed
phet-steele opened this issue Feb 24, 2017 · 11 comments

Comments

@phet-steele
Copy link

From @BryceAG in phetsims/tasks#764 (comment)

On Win 7, IE the splash will pop up in the top left corner for a brief moment, then center itself. Happens regardless of window size.

Verified on Win 7 and 8.1, IE11 with this link http://www.colorado.edu/physics/phet/dev/html/energy-skate-park-basics/1.3.1-dev.3/energy-skate-park-basics_en.html

@samreid
Copy link
Member

samreid commented Feb 24, 2017

Could it be related to the CSS in #407 ?

@samreid
Copy link
Member

samreid commented Mar 16, 2017

#407 was attributed to a minor image dimension change. We can see if an image size problem is causing this issue as well (say, if the image has size 0,0) at the beginning.

@samreid
Copy link
Member

samreid commented Aug 9, 2017

I can still see the problem in my virtual box IE11 for http://www.colorado.edu/physics/phet/dev/html/energy-skate-park-basics/1.3.1-dev.3/energy-skate-park-basics_en.html

However, when testing with a built faradays law using the fix from #407 I no longer see the problem.

@samreid
Copy link
Member

samreid commented Aug 9, 2017

@samreid
Copy link
Member

samreid commented Aug 9, 2017

Well it is still a problem in that version, not sure why.

@samreid
Copy link
Member

samreid commented Aug 9, 2017

@jonathanolson and I considered the following strategies:

  1. Let it be buggy on IE11 (the splash screen starts in the top left then jumps to the middle)
  2. Don't show any loading/splash screen on IE11
  3. Show the loading bar but no image on IE11
  4. Rasterize the splash images instead of using SVG
  5. Hard code the image sizes in code (may get out of sync and be harder for 3rd parties to add their own logo)

@samreid
Copy link
Member

samreid commented Aug 9, 2017

I went with (2) for now since it was extremely simple to implement. @ariel-phet can you please recommend a way to proceed here? We are not sure how much time to spend getting the splash screen to look good on IE.

@ariel-phet
Copy link

ariel-phet commented Aug 10, 2017

@samreid I think i would rather leave it buggy then have no splash/loading screen. A blank screen might make the user think the sim is not loading on a slower internet connection with IE.

@samreid
Copy link
Member

samreid commented Aug 12, 2017

This is out for testing in the aforementioned issue.

@phet-steele
Copy link
Author

Doesn't really look like there is anything here to test? There was a commit that changed some things, then a second commit that just reverted it. Yes...it is still buggy on IE11 but that's what we expected. @samreid should we mark this deferred (or wontfix) and leave open for later?

@samreid
Copy link
Member

samreid commented Aug 14, 2017

I guess close as wontfix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants