Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate global sound controls into sim framework #497

Closed
jbphet opened this issue Jul 9, 2018 · 12 comments
Closed

Integrate global sound controls into sim framework #497

jbphet opened this issue Jul 9, 2018 · 12 comments

Comments

@jbphet
Copy link
Contributor

jbphet commented Jul 9, 2018

There are two sound controls that need to be added into the sim framework, one for turning sound on and off for the sim, and another for choosing between "basic" and "enhanced" sounds.

The issues where this was previously discussed are:

The UI design is being finalized in:

In the 7/9/2018 sonification framework design meeting we decided that this should be committed to a branch on joist until the Equality Explorer release branch is created in order to minimize the risk of destabilizing core framework code.

@jbphet jbphet self-assigned this Jul 9, 2018
@jbphet
Copy link
Contributor Author

jbphet commented Jul 9, 2018

I committed some code for this but forgot to reference the issue, please see 4dd92fc.

jbphet added a commit that referenced this issue Jul 10, 2018
pixelzoom added a commit to phetsims/chipper that referenced this issue Jul 13, 2018
pixelzoom added a commit to phetsims/chipper that referenced this issue Jul 13, 2018
@pixelzoom
Copy link
Contributor

pixelzoom commented Jul 13, 2018

@jbphet said:

... we decided that this should be committed to a branch on joist until the Equality Explorer release branch is created in order to minimize the risk of destabilizing core framework code.

RCs are published for Equality Explorer, so you may proceed with merging into master.

@jbphet
Copy link
Contributor Author

jbphet commented Jul 17, 2018

@samreid - since the Equality Explorer RC is out, please review the code on the sound-control branch and let me know what if anything needs to be done before merging it to master. One exception: for now, please don't spend any time on NavigationBarSoundToggleButton, since we are looking at ways to reduce the amount of memory that it used.

@samreid samreid self-assigned this Jul 17, 2018
@jbphet jbphet removed their assignment Jul 17, 2018
chrisklus pushed a commit that referenced this issue Jul 18, 2018
samreid added a commit to phetsims/chipper that referenced this issue Jul 18, 2018
samreid added a commit to phetsims/tambo that referenced this issue Jul 18, 2018
samreid added a commit that referenced this issue Jul 18, 2018
@samreid
Copy link
Member

samreid commented Jul 18, 2018

In the preceding 3 commits (note these are for 3 repos), I added review comments for the proposed changes. @jbphet please take a look?

@jbphet jbphet assigned jonathanolson and unassigned jbphet Jul 23, 2018
jonathanolson added a commit to phetsims/area-model-common that referenced this issue Jul 23, 2018
jonathanolson added a commit to phetsims/axon that referenced this issue Jul 23, 2018
jonathanolson added a commit to phetsims/balloons-and-static-electricity that referenced this issue Jul 23, 2018
jonathanolson added a commit to phetsims/circuit-construction-kit-common that referenced this issue Jul 23, 2018
jonathanolson added a commit to phetsims/dot that referenced this issue Jul 23, 2018
jonathanolson added a commit to phetsims/kite that referenced this issue Jul 23, 2018
jonathanolson added a commit to phetsims/phet-core that referenced this issue Jul 23, 2018
jonathanolson added a commit to phetsims/phetcommon that referenced this issue Jul 23, 2018
jonathanolson added a commit to phetsims/query-string-machine that referenced this issue Jul 23, 2018
jonathanolson added a commit to phetsims/tandem that referenced this issue Jul 23, 2018
jonathanolson added a commit to phetsims/twixt that referenced this issue Jul 23, 2018
@jonathanolson
Copy link
Contributor

I ran grunt update on every active-repo (perennial/bin/for-each.sh active-repos grunt update and committed the results (omitting interaction-dashboard).

@jbphet I believe the config files are now correct. Is there some place we should document how to update dependencies?

@jbphet
Copy link
Contributor Author

jbphet commented Jul 24, 2018

Thanks for the fix.

Is there some place we should document how to update dependencies?

Sure. Maybe a new document in phet-info/doc? The challenge will be remembering that it exists and using it when needed and keeping it updated, since adding a new dependency is a pretty rare event. I would suggest creating it (it should be quite short, right?) then marking for dev meeting to see if people agree with the location and just to let the other devs know that it exists.

@jonathanolson
Copy link
Contributor

Added phet-info/checklists/updating_metadata.md (fits as a checklist). Tagging for developer meeting to see if anything needs to change.

@jonathanolson
Copy link
Contributor

https://github.com/phetsims/phet-info/blob/master/checklists/updating_metadata.md

@pixelzoom
Copy link
Contributor

samreid pushed a commit to phetsims/phet-info that referenced this issue Apr 23, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants