Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How should we control sound on/off in sonified sims? #11

Closed
jbphet opened this issue Jun 14, 2018 · 6 comments
Closed

How should we control sound on/off in sonified sims? #11

jbphet opened this issue Jun 14, 2018 · 6 comments
Assignees

Comments

@jbphet
Copy link
Contributor

jbphet commented Jun 14, 2018

Sonification enabled/disabled is going to be a global setting. How should the user control it?

@jbphet
Copy link
Contributor Author

jbphet commented Jun 14, 2018

This was discussed in the 6/14/2018 design meeting, and we decided to add a smallish control to the right side of the nav bar.

@jbphet
Copy link
Contributor Author

jbphet commented Jun 14, 2018

@samreid suggested looking at KeyboardHelpButton button as an example of how to add this.

@jbphet
Copy link
Contributor Author

jbphet commented Jun 14, 2018

@pixelzoom pointed out that there is a flag named accessible that is supported in the package.json files for each sim that is used to control whether the KeyboardHelpButton is enabled, so I should look at how that is used and follow a similar pattern for how a sim decides whether to display and hook up the volume on/off button.

@jbphet
Copy link
Contributor Author

jbphet commented Jun 14, 2018

During the design meeting mentioned above, we decided that I'd prototype this and present it to the group rather than having anyone create mockups first.

@jbphet jbphet self-assigned this Jun 14, 2018
@pixelzoom
Copy link
Contributor

Re #11 (comment)...

Since the sound button applies to both "basic" and "enhanced" (sonification) sound, I think the appearance of the button in the navigation bar more likely depends on whether a Sound manager has been instantiated. The controls for selecting between "basic" and "enhanced" in the PhET menu may require option(s), to indicate whether the sim supports "basic" and/or "enhanced" sounds.

@jbphet
Copy link
Contributor Author

jbphet commented Jul 24, 2018

The sound on/off button has been added to the nav bar (see the issue referenced above for the commits). I think it's okay to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants