Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to set the sonification level #12

Closed
jbphet opened this issue Jun 14, 2018 · 3 comments
Closed

Add ability to set the sonification level #12

jbphet opened this issue Jun 14, 2018 · 3 comments
Assignees
@emily-phet

Comments

@jbphet
Copy link
Contributor

jbphet commented Jun 14, 2018

Sonification supports two levels, "basic" and "enhanced". The user needs to be able to select the setting.
@jbphet
Copy link
Contributor Author

jbphet commented Jun 14, 2018

We discussed this in the 6/14/2018 developer meeting and decided to put this on the PhET menu, and have it behave the way the "Full Screen" option behaves, which is to say that selecting it will turn on enhanced sound and will put a check mark in the menu next to the item. There was some concern that having this control be separated from the sound on/off button wasn't ideal, but @emily-phet pointed out that this control will eventually be part of a larger set of accessibility-related controls that will be grouped together and available via the PhET menu, so having it on the menu (albeit by itself for now) is a reasonable choice.

@jbphet
Copy link
Contributor Author

jbphet commented Jun 14, 2018

@emily-phet - how about having the label for this be "Enhanced Sound"?

@jbphet jbphet mentioned this issue Jul 9, 2018
Closed
jbphet added a commit to phetsims/phetmarks that referenced this issue Jul 10, 2018
@jbphet
added support for setting enhanced sound mode from the PhET menu, see p…
0fdadd8 
…hetsims/tambo#12 and phetsims/joist#497
jbphet added a commit to phetsims/chipper that referenced this issue Jul 10, 2018
@jbphet
added support for setting enhanced sound mode from the PhET menu, see p…
22120dd 
…hetsims/tambo#12 and phetsims/joist#497
jbphet added a commit to phetsims/joist that referenced this issue Jul 10, 2018
@jbphet
added support for setting enhanced sound mode from the PhET menu, see p…
c636033 
…hetsims/tambo#12 and #497
jbphet added a commit that referenced this issue Jul 10, 2018
@jbphet
added support for setting enhanced sound mode from the PhET menu, see #…
d19da38 
…12 and phetsims/joist#497
pixelzoom added a commit to phetsims/chipper that referenced this issue Jul 13, 2018
@pixelzoom
move tambo query parameter to maintain alphabetical order, phetsims/t…
fb8805f 
…ambo#12, phetsims/joist#497

Signed-off-by: Chris Malley <cmalley@pixelzoom.com>
pixelzoom added a commit to phetsims/chipper that referenced this issue Jul 13, 2018
@pixelzoom
move supportsEnhancedSound query parameter to maintain alphabetical o…
a03dabe 
…rder, phetsims/tambo#12, phetsims/joist#497

Signed-off-by: Chris Malley <cmalley@pixelzoom.com>
jbphet added a commit to phetsims/joist that referenced this issue Jul 20, 2018
@jbphet
added support for setting enhanced sound mode from the PhET menu, see p…
9b40f9f 
…hetsims/tambo#12 and #497
@jbphet
Copy link
Contributor Author

jbphet commented Aug 23, 2018

I've used the "Enhanced Sound" string, and it's been in place for a while with no objections. I'm going to go ahead and close this issue.

@jbphet jbphet closed this as completed Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emily-phet emily-phet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbphet @emily-phet