-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues related to pdomPlayAreaNode and pdomControlAreaNode #721
Comments
I should also point out that (with the current implementation) if any Nodes are added to the ScreenView directly, they will be (by default) in front of While I understand the concepts of "play area" and "control area" and their benefit, I think that the current implementation is going to cause many UX and implementation problems. Have you considered decoupling these concepts from the scene graph order? |
6/10/2021 design meeting @jessegreenberg @arouinfar @kathy-phet @KatieWoe @pixelzoom The current was specified based on pdomOrder needs. But this.pdomPlayAreaNode should be in front of this.pdomControlAreaNode, and pDomOrder should be set explicitly for this.pdomParentNode. Over in phetsims/vegas#93, @jessegreenberg said that in situations like this, rather than adding children to @jessegreenberg suggested that, going forward, setting pdomOrder for pdomPlayAreaNode and pdomControlAreaNode is a better approach than addChild for those Nodes. @kathy-phet asked @jessegreenberg to make a PSA about this new approach for "play area" and "control area". |
I just updated documentation in the interactive-description-technical-guide.md to reflect this change, Ill add to dev meeting agenda to describe this and the benefits to the team. |
This was discussed during developer meeting today. We reviewed that I made #722 to swap the order of pdomControlAreaNode and pdomControlAreaNode as children but keeping their same order in the PDOM. Reviewing comments here I think that is all that is left for this general issue, closing. |
@zepumph and I reviewed this during a catch-up meeting today and discussed what was decided in this issue. We found a few places where the documentation could be improved related to this in interactive-description-technical-guide.md in the section related to |
Discovered while working on phetsims/fourier-making-waves#76 (play area and control area for Fourier).
In ScreenView.js,
So the
pdomPlayAreaNode
is behind thepdomControlAreaNode
. This seems backwards. In all of the sims that I've implemented, draggable objects (which I suspect would be in the play area) need to stay in front of controls. A couple of general reasons for this: First, it's a much better UX if youmoveToFront
when you start dragging an object. Second, you don't want to release a draggable object behind a control panel, where it would then be "lost" (unreachable).@jessegreenberg thoughts?
The text was updated successfully, but these errors were encountered: