Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

localeProperty should be part of PreferencesModel #847

Closed
zepumph opened this issue Aug 26, 2022 · 2 comments
Closed

localeProperty should be part of PreferencesModel #847

zepumph opened this issue Aug 26, 2022 · 2 comments
Assignees
@jessegreenberg
Labels
status:ready-for-review

Comments

@zepumph
Copy link
Member

zepumph commented Aug 26, 2022

From #840 (comment), and the work we did in #743. We shouldn't pull in globals, but instead pass them through the preferencesModel.localizationModel
@zepumph zepumph self-assigned this Aug 26, 2022
zepumph added a commit that referenced this issue Aug 26, 2022
@zepumph
in preferences, dependency inject localeProperty instead of using the…
e991aff 
… global, #847
@zepumph
Copy link
Member Author

zepumph commented Aug 26, 2022

@jessegreenberg can you please review.

@zepumph zepumph assigned jessegreenberg and unassigned zepumph Aug 26, 2022
@zepumph zepumph mentioned this issue Aug 26, 2022
Closed
@jessegreenberg
Copy link
Contributor

This is great, thanks!

zepumph added a commit that referenced this issue Aug 26, 2022
@zepumph
bug fix, #847
2fc9967
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessegreenberg jessegreenberg

Labels
status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jessegreenberg @zepumph