Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a superclass for content in Preferences panels #867

Closed
jessegreenberg opened this issue Sep 22, 2022 · 1 comment
Closed

Create a superclass for content in Preferences panels #867

jessegreenberg opened this issue Sep 22, 2022 · 1 comment
Assignees
@jessegreenberg

Comments

@jessegreenberg
Copy link
Contributor

#860 would be much easier if there were a superclass for Preferences panel content. Mostly to manage visibility in that issue, but there is also some duplication between all of the *PreferencesPanel.ts files in joist/preferences.
@jessegreenberg jessegreenberg self-assigned this Sep 22, 2022
@jessegreenberg jessegreenberg mentioned this issue Sep 22, 2022
Closed
jessegreenberg added a commit that referenced this issue Sep 22, 2022
@jessegreenberg
Supertype PreferencesPanel to manage visibility and other shared thin…
8239331 
…gs, see #867
@jessegreenberg
Copy link
Contributor Author

This is done and working well for the requests in #860.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessegreenberg jessegreenberg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jessegreenberg