Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace hasKeyboardHelpContent with "if any simScreen supplies keyboardHelpContent" #876

Closed
zepumph opened this issue Oct 25, 2022 · 1 comment
Closed

Replace hasKeyboardHelpContent with "if any simScreen supplies keyboardHelpContent" #876

zepumph opened this issue Oct 25, 2022 · 1 comment
Assignees
@zepumph
Labels
priority:2-high

Comments

@zepumph
Copy link
Member

zepumph commented Oct 25, 2022

Right now we duplicate a flag on sim and screens, but I think we can just use the presence of an option in each screen to determine if we support keyboard help. Noting and assigning myself. Please @jessegreenberg, let me know if you want to discuss this further.
@zepumph zepumph self-assigned this Oct 25, 2022
@zepumph zepumph mentioned this issue Oct 25, 2022
Closed
@jessegreenberg
Copy link
Contributor

Yes, removing the sim option seems like a good thing to do.

zepumph added a commit to phetsims/geometric-optics that referenced this issue Oct 26, 2022
@zepumph
derive hasKeyboardHelpContent from the presence of creation nodes, ph…
7538029 
…etsims/joist#876
zepumph added a commit to phetsims/fourier-making-waves that referenced this issue Oct 26, 2022
@zepumph
derive hasKeyboardHelpContent from the presence of creation nodes, ph…
3dbbb17 
…etsims/joist#876
zepumph added a commit to phetsims/gravity-force-lab-basics that referenced this issue Oct 26, 2022
@zepumph
derive hasKeyboardHelpContent from the presence of creation nodes, ph…
7e5860b 
…etsims/joist#876
zepumph added a commit to phetsims/coulombs-law that referenced this issue Oct 26, 2022
@zepumph
derive hasKeyboardHelpContent from the presence of creation nodes, ph…
3b6ec01 
…etsims/joist#876
zepumph added a commit to phetsims/ratio-and-proportion that referenced this issue Oct 26, 2022
@zepumph
derive hasKeyboardHelpContent from the presence of creation nodes, ph…
44e1cc1 
…etsims/joist#876
zepumph added a commit to phetsims/balloons-and-static-electricity that referenced this issue Oct 26, 2022
@zepumph
derive hasKeyboardHelpContent from the presence of creation nodes, ph…
5ceb50a 
…etsims/joist#876
zepumph added a commit to phetsims/gravity-force-lab that referenced this issue Oct 26, 2022
@zepumph
derive hasKeyboardHelpContent from the presence of creation nodes, ph…
4434f54 
…etsims/joist#876
zepumph added a commit to phetsims/ohms-law that referenced this issue Oct 26, 2022
@zepumph
derive hasKeyboardHelpContent from the presence of creation nodes, ph…
7fc555e 
…etsims/joist#876
zepumph added a commit to phetsims/plinko-probability that referenced this issue Oct 26, 2022
@zepumph
derive hasKeyboardHelpContent from the presence of creation nodes, ph…
c329398 
…etsims/joist#876
zepumph added a commit to phetsims/mean-share-and-balance that referenced this issue Oct 26, 2022
@zepumph
derive hasKeyboardHelpContent from the presence of creation nodes, ph…
3ffccb3 
…etsims/joist#876
zepumph added a commit to phetsims/ph-scale-basics that referenced this issue Oct 26, 2022
@zepumph
derive hasKeyboardHelpContent from the presence of creation nodes, ph…
c8621f7 
…etsims/joist#876
zepumph added a commit to phetsims/tambo that referenced this issue Oct 26, 2022
@zepumph
derive hasKeyboardHelpContent from the presence of creation nodes, ph…
7d8bd90 
…etsims/joist#876
zepumph added a commit to phetsims/molecules-and-light that referenced this issue Oct 26, 2022
@zepumph
derive hasKeyboardHelpContent from the presence of creation nodes, ph…
8003198 
…etsims/joist#876
zepumph added a commit to phetsims/john-travoltage that referenced this issue Oct 26, 2022
@zepumph
derive hasKeyboardHelpContent from the presence of creation nodes, ph…
5883df8 
…etsims/joist#876
zepumph added a commit to phetsims/ph-scale that referenced this issue Oct 26, 2022
@zepumph
derive hasKeyboardHelpContent from the presence of creation nodes, ph…
a8c5a0a 
…etsims/joist#876
zepumph added a commit to phetsims/faradays-law that referenced this issue Oct 26, 2022
@zepumph
derive hasKeyboardHelpContent from the presence of creation nodes, ph…
4d4e0de 
…etsims/joist#876
zepumph added a commit to phetsims/molarity that referenced this issue Oct 26, 2022
@zepumph
derive hasKeyboardHelpContent from the presence of creation nodes, ph…
9407d05 
…etsims/joist#876
zepumph added a commit to phetsims/phet-info that referenced this issue Oct 26, 2022
@zepumph
derive hasKeyboardHelpContent from the presence of creation nodes, ph…
e1df774 
…etsims/joist#876
zepumph added a commit to phetsims/greenhouse-effect that referenced this issue Oct 26, 2022
@zepumph
derive hasKeyboardHelpContent from the presence of creation nodes, ph…
6dac5e7 
…etsims/joist#876
zepumph added a commit to phetsims/resistance-in-a-wire that referenced this issue Oct 26, 2022
@zepumph
derive hasKeyboardHelpContent from the presence of creation nodes, ph…
d3ff1db 
…etsims/joist#876
zepumph added a commit to phetsims/friction that referenced this issue Oct 26, 2022
@zepumph
derive hasKeyboardHelpContent from the presence of creation nodes, ph…
40fe12f 
…etsims/joist#876
zepumph added a commit that referenced this issue Oct 26, 2022
@zepumph
derive hasKeyboardHelpContent from the presence of creation nodes, #876
0348152
zepumph added a commit to phetsims/quadrilateral that referenced this issue Oct 26, 2022
@zepumph
derive hasKeyboardHelpContent from the presence of creation nodes, ph…
8311254 
…etsims/joist#876
zepumph added a commit to phetsims/scenery-phet that referenced this issue Oct 26, 2022
@zepumph
derive hasKeyboardHelpContent from the presence of creation nodes, ph…
2fa1693 
…etsims/joist#876
@zepumph zepumph closed this as completed Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepumph zepumph

Labels
priority:2-high
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jessegreenberg @zepumph