Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shape.union takes a really long time and sometimes says "Error: TODO: Need to implement more advanced disambiguation" #98

Open
samreid opened this issue Aug 1, 2022 · 1 comment
Assignees
Labels

Comments

@samreid
Copy link
Member

samreid commented Aug 1, 2022

@marlitas and I were able to reproduce the bug reported in phetsims/mean-share-and-balance#87 in both Mac/Safari and Mac/Chrome. We isolated the problem to Shape.union which is being called in BeakerNode.

Perhaps the shapes being passed to Shape.union are triggering a difficult situation or corner case that kite is struggling with.

@marlitas and I will look for another way to render BeakerNode for the moment, but wanted to raise this issue for @jonathanolson to investigate. May be best to collaborate with @marlitas to discuss how to trigger the error case.

@marlitas wonders if this is related to: #97

@zepumph
Copy link
Member

zepumph commented May 10, 2023

eff96db will unblock MSS so that things can be graceful in production, @jonathanolson would like to fix this at some point though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants